Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

C++: updated windows build with curl lib #5282

Merged
merged 2 commits into from
Aug 21, 2023
Merged

C++: updated windows build with curl lib #5282

merged 2 commits into from
Aug 21, 2023

Conversation

meyertst-aws
Copy link
Contributor

@meyertst-aws meyertst-aws commented Aug 18, 2023 •
edited
Loading

This has no SOS or documentation changes.
Updated some comments.
Updated CMakeLists.txt
Enabled build of list_buckets_disabling_dns_cache.cpp on windows when using curl library

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@meyertst-aws meyertst-aws added C++ This issue relates to the AWS SDK for C++ On Call Review needed This work needs an on-call review Text Review not needed This contains no text which needs review labels Aug 18, 2023
@meyertst-aws meyertst-aws requested a review from a team August 18, 2023 14:41
@meyertst-aws meyertst-aws self-assigned this Aug 18, 2023
@meyertst-aws meyertst-aws requested review from Laren-AWS and removed request for a team August 18, 2023 14:41
@meyertst-aws meyertst-aws added On Call Review needed This work needs an on-call review and removed On Call Review needed This work needs an on-call review labels Aug 18, 2023
@ford-at-aws ford-at-aws added On Call Review complete On call review complete and removed On Call Review needed This work needs an on-call review labels Aug 21, 2023
@meyertst-aws meyertst-aws force-pushed the 5252-enable-windows-build-of-c++-file-in-special-case branch from c526bf4 to 207d56d Compare August 21, 2023 15:14
@meyertst-aws meyertst-aws force-pushed the 5252-enable-windows-build-of-c++-file-in-special-case branch from 207d56d to f842e7c Compare August 21, 2023 15:15
@ford-at-aws ford-at-aws merged commit 7853de4 into awsdocs:main Aug 21, 2023
8 checks passed
@meyertst-aws meyertst-aws deleted the 5252-enable-windows-build-of-c++-file-in-special-case branch September 7, 2023 20:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ford-at-aws ford-at-aws ford-at-aws approved these changes

@Laren-AWS Laren-AWS Awaiting requested review from Laren-AWS Laren-AWS was automatically assigned from awsdocs/aws-sdk-docs-code-maintainers

Assignees

@meyertst-aws meyertst-aws

Labels
C++ This issue relates to the AWS SDK for C++ On Call Review complete On call review complete Text Review not needed This contains no text which needs review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@meyertst-aws @ford-at-aws